bug: delete a project even if the current state is destroyed #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Nov 22, 2023
Comment on lines
+1388
to
+1394
| #[test_context(TestProject)] | ||
| #[tokio::test] | ||
| async fn api_delete_project_that_is_ready(project: &mut TestProject) -> anyhow::Result<()> { | ||
| project.router_call(Method::DELETE, "/delete").await; | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Clean! 😍 Can we apply these utilities for the existing tests as well, and break them up into smaller pieces (looking at you api_create_get_delete_projects)? We can do it in a later PR to not block this for tomorrows release.
There was a problem hiding this comment.
Yip, getting to them in another PR is the plan.... and maybe even adding them to the end of CI after the image builds 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Causes the delete command to start up destroyed (stopped) projects to be able to delete them.
How has this been tested? (if applicable)
By making new gateway tests. Use the following steps to run them
If your tests take too long to run and eventually errors with
503then make sure your firewall is not blocking any requests. See comments in the code.